Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inactive regions when determining folding ranges #6667

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Handle inactive regions when determining folding ranges #6667

merged 3 commits into from
Dec 15, 2020

Conversation

Colengms
Copy link
Contributor

When combined with the associated native PR, addresses: #5429
Also addresses: #6569 (which is just an enum value change from "member" -> "method")

Also fixed an issue that would cause semantic tokens not to refresh properly after a manual change of the C_Cpp.enhancedColorization setting.

sean-mcmanus
sean-mcmanus requested changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

"minimumVSCodeVersion": "1.49.0"

this needs to be updated too -- and the new cpptools.json published.

@Colengms Colengms merged commit 805f884 into master Dec 15, 2020
@Colengms Colengms deleted the coleng/folding_with_inactive_regions branch December 15, 2020 00:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Colengms @sean-mcmanus