Work around issue with getting stale contents from openTextDocument #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Apr 27, 2019
added 3 commits
April 29, 2019 14:12
… writeFile. Unsubscribe from window activation when settings UI is not visible.
…icrosoft/vscode-cpptools into coleng/changeNotificationIssue
michelleangela
approved these changes
Apr 29, 2019
bobbrow
reviewed
Apr 29, 2019
| @@ -681,11 +699,6 @@ export class CppProperties { | |||
| } | |||
|
|
|||
| let fullPathToFile: string = path.join(this.configFolder, "c_cpp_properties.json"); | |||
| let filePath: vscode.Uri = vscode.Uri.file(fullPathToFile).with({ scheme: "untitled" }); | |||
|
|
|||
| let document: vscode.TextDocument = await vscode.workspace.openTextDocument(filePath); | |||
There was a problem hiding this comment.
I was thinking that this would open and (potentially) focus the file in the editor. Are we doing anything to maintain that behavior with this new approach?
bobbrow
approved these changes
Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one of the scenarios discussed in this vscode issue: microsoft/vscode#72831
Using openTextDocument in response to a FileSystemWatcher.onDidChange may result in reading stale (cached) contents, if the file is already opened by vscode. This can be worked around by instead waiting for onDidChangeTextDocument to fire for the file.