-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify users if there's a pre-release version available. #11569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spebl
requested review from
fearthecowboy,
bobbrow,
sean-mcmanus,
Colengms,
AlexandraKemperMS and
browntarik
October 23, 2023 19:29
sean-mcmanus
requested changes
Oct 23, 2023
browntarik
reviewed
Oct 23, 2023
Colengms
requested changes
Oct 23, 2023
bobbrow
reviewed
Oct 23, 2023
… pop up constantly
Colengms
requested changes
Oct 24, 2023
bobbrow
previously approved these changes
Oct 24, 2023
Colengms
previously approved these changes
Oct 24, 2023
sean-mcmanus
previously approved these changes
Oct 24, 2023
sean-mcmanus
approved these changes
Oct 24, 2023
Colengms
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if there's a pre-release available and that the user isn't already using it, and if so, pop up a prompt to see if they want to install it. A little tough to test this locally, but the parts I can't test I've taken from previous PRs/other MS vscode extensions. Any tips to test the pre-release check (from __metadata) and the install command (took it from a previous related PR) is very welcome, as well as any other comments on the code style/use since it's my first PR in the space.