Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users if there's a pre-release version available. #11569

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

spebl
Copy link
Contributor

@spebl spebl commented Oct 23, 2023

Check if there's a pre-release available and that the user isn't already using it, and if so, pop up a prompt to see if they want to install it. A little tough to test this locally, but the parts I can't test I've taken from previous PRs/other MS vscode extensions. Any tips to test the pre-release check (from __metadata) and the install command (took it from a previous related PR) is very welcome, as well as any other comments on the code style/use since it's my first PR in the space.

Extension/src/LanguageServer/extension.ts Outdated Show resolved Hide resolved
Extension/src/LanguageServer/extension.ts Show resolved Hide resolved
@bobbrow bobbrow linked an issue Oct 23, 2023 that may be closed by this pull request
bobbrow
bobbrow previously approved these changes Oct 24, 2023
Colengms
Colengms previously approved these changes Oct 24, 2023
@spebl spebl dismissed stale reviews from Colengms and bobbrow via e49fe06 October 24, 2023 21:53
sean-mcmanus
sean-mcmanus previously approved these changes Oct 24, 2023
@spebl spebl merged commit 8fbc56a into main Oct 24, 2023
4 checks passed
@spebl spebl deleted the dev/spebl/prerelease branch October 24, 2023 23:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore the prompt to install our pre-release
5 participants