Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change clang-format "Visual Studio" fallback style to use NamespaceIndentation All #5124

Closed
sean-mcmanus opened this issue Mar 16, 2020 · 1 comment
Closed

Change clang-format "Visual Studio" fallback style to use NamespaceIndentation All #5124

sean-mcmanus opened this issue Mar 16, 2020 · 1 comment
Assignees
@elahehrashedi
Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone
0.28.0

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Mar 16, 2020 •
edited
Loading

It currently defaults to None. The fix should only require, adding text ", NamespaceIndentation: All" to the description of the clang_format_fallbackStyle in TypeScript and to the clang_format_style variable on the language server.

Unless we think VS's default formatting should be changed instead.
@sean-mcmanus sean-mcmanus added bug quick fix Feature: Code Formatting Works in VS So we'd need to fix it for VS Code to reach parity. labels Mar 16, 2020
@bobbrow bobbrow added this to the 1.0 milestone Mar 17, 2020
@sean-mcmanus sean-mcmanus mentioned this issue Mar 18, 2020
Closed
@michelleangela michelleangela mentioned this issue Mar 19, 2020
Merged
elahehrashedi pushed a commit that referenced this issue Mar 30, 2020
fix Bug 5124, adding namespace indent
e2e1868 
* fix Bug 5124, adding namespace indent
#5124
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 31, 2020
@elahehrashedi
Copy link
Contributor

This issue is fixed in 0.28.0.
0.28.0 release: https://github.com/microsoft/vscode-cpptools/releases/tag/0.28.0

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elahehrashedi elahehrashedi

Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Milestone
0.28.0
Development

No branches or pull requests
3 participants
@bobbrow @elahehrashedi @sean-mcmanus