Update git-commit icon

[daviddossett]

Updates git-commit to feature a centered vertical stroke and slightly thicker circle stroke. This enables the icon to be in proper alignment with the circle-outline icon that it's now paired with in the Timeline view.

[miguelsolorio]

Hmm...my concern is that it's another similar icon and people looking at the icons might not know why they are different. We run into this issue with the debugger play button (which is thicker) and the regular play button.

Did you try updating the git-commit to have the same weight and positioning instead?

[daviddossett]

Yeah, I definitely share the concern. One challenge with updating git-commit to use the outline from circle-outline is the inherent offset used in git-commit to visually center the 1px vertical stroke. It would end up looking something like this:

[miguelsolorio]

I see that problem, even though we would want to have everything aligned to the pixel grid as much as possible, the vertical line would need to be adjusted and be off-grid. I think I'd rather have that instead of introducing another similar icon.

And backstory on the thicker stroke, the circle outline was actually used only for unverified breakpoints and so the entire breakpoint icons have a slight thicker stroke to stand out in smaller sizes. I think we're a bit inconsistent with this style and can see updating other places where they aren't.

[daviddossett]

Here's how it could look to update git-commit to use the thicker stroke + centered line straddling the grid:

[miguelsolorio]

LGTM, do you think we should also update the line to be the same stroke weight? also realize that this might make the rest of the git icons a bit inconsistent so not sure if it's worth it

[miguelsolorio]

Feel free to update the codicons file on the vscode repo

[daviddossett]

do you think we should also update the line to be the same stroke weight? also realize that this might make the rest of the git icons a bit inconsistent so not sure if it's worth it

I thought about this and felt it was a better compromise to leave it as is. It felt pretty heavy when I tried (it in addition the the consistency issue).

[daviddossett]

Updated codicons file: microsoft/vscode@dc58d4e