determine shell for .cmd, .bat, .ps1 #4044
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2024
gcampbell-msft
force-pushed
the
dev/gcampbell/SpawnShellFix
branch
from
9dabad7 to
6fca2da
Compare
gcampbell-msft
force-pushed
the
dev/gcampbell/SpawnShellFix
branch
from
9056f9b to
dae8c00
Compare
Merged
|
Likely need more logic for only doing determine shell on Windows. |
|
@moyo1997 ping for review, thanks! |
snehara99
reviewed
Oct 9, 2024
gcampbell-msft
force-pushed
the
dev/gcampbell/SpawnShellFix
branch
from
6f13615 to
6ea5dd2
Compare
snehara99
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test VSIX:
cmake-tools.zip
Fixes #4037. Fixes #4042
We did not change anything regarding this between 1.18 and 1.19. This issue comes from a breaking change in VS Code, where in version 1.92, which came out in July, they update to node v20 which requires more strict options regarding proc.spawn: Visual Studio Code July 2024.