Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent second configure after QuickStart if the automaticReconfigure setting is enabled #3933

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Prevent second configure after QuickStart if the automaticReconfigure setting is enabled #3933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e08c34f
check for quick start in select configure preset to prevent second co…
qarni Jul 24, 2024
4902d87
Merge branch 'main' into dev/qarni/secondConfigure
gcampbell-msft Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Bug Fixes:
- Disable annoy and invalid extenion message about fix windows sdk for MSVC 2022. [#3837](https://github.com/microsoft/vscode-cmake-tools/pull/3837)
- Fix re-using a terminal for launching even when the environment has changed. [#3478](https://github.com/microsoft/vscode-cmake-tools/issues/3478)
- Fix our keybindings for debug and run without debugging to better match VS Code. [#3507](https://github.com/microsoft/vscode-cmake-tools/issues/3507)
- Prevent second configure after `QuickStart` if the `automaticReconfigure` setting is enabled. [#3910](https://github.com/microsoft/vscode-cmake-tools/issues/3910)

## 1.18.43

Expand Down
2 changes: 1 addition & 1 deletion src/presetsController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ export class PresetsController {
await this.setConfigurePreset(chosenPreset);
}

if (this.project.workspaceContext.config.automaticReconfigure) {
if (this.project.workspaceContext.config.automaticReconfigure && !quickStart) {
await this.project.configureInternal(ConfigureTrigger.selectConfigurePreset, [], ConfigureType.Normal);
}
return !addPreset || allPresets.length === 0;
Expand Down
Loading