Fix1639 - Allow configure arguments overrides #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow user to override the usual args passed by the extention towards cmake via configureSettings
gcampbell-msft
previously approved these changes
Jul 28, 2023
snehara99
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for request #1639. Don't have unremovable options for the configure command. Allow user to override the usual args passed by the extention towards cmake via configureSettings.
The easy way to address this is to make sure we append the configure settings last in the configure command, not first as they were. For example, a user defined CMAKE_BUILD_TYPE would be passed to cmake but immediately overwritten by our default calculation. Since cmake can take multiple appearances of the same switch and the last one wins, makes sense to append configure settings (which come from the user) last.