allows build target to display when using presets #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snehara99 Before approving, could you help me understand exactly what the change is by putting some screenshots in of before and after? The changes seem fine, but I want to make sure I understand it well before I approve. Thanks! |
benmcmorran
previously approved these changes
Jul 18, 2023
…ub.com/microsoft/vscode-cmake-tools into dev/snehara/add-build-target-selection
gcampbell-msft
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build target shows in the Project Status View in the side panel now and mimics the same behaviour of the option in the status bar. Below are before and after screenshots when using CMake Presets.
Before (can't select build target):
After (can select build target):
