Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to select either C or C++ with the Quick Start commmand. #3183

Merged
merged 5 commits into from
May 19, 2023
Merged

Conversation

REDl3east
Copy link
Contributor

This change addresses item #3182

This changes the Quick Start command to include an option to specify either C or C++.

The following changes are proposed:

  • Made the Quick Start relevant source files given the language selected. .cpp for C++ and .c for C.
  • Added LANGUAGES to the generated CMakeLists.txt file.
  • Generating similar source files to C++, except it uses stdio.h instead of iostream.

The purpose of this change

This pull request is for the convenience of C programmers.

@REDl3east
Copy link
Contributor Author

@microsoft-github-policy-service agree

@benmcmorran benmcmorran added this to the 1.15 milestone May 18, 2023
Copy link
Member

@benmcmorran benmcmorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! In addition to the comments I left in the source code, please add an entry to CHANGELOG.md under 1.15.0 in a new "Features:" list and optionally give yourself credit. See other entries from earlier releases for reference.

src/cmakeProject.ts Outdated Show resolved Hide resolved
src/cmakeProject.ts Outdated Show resolved Hide resolved
src/cmakeProject.ts Outdated Show resolved Hide resolved
@benmcmorran benmcmorran self-assigned this May 18, 2023
@benmcmorran benmcmorran merged commit c3b9bfe into microsoft:main May 19, 2023
@benmcmorran
Copy link
Member

Thanks again! These changes should be available in the pre-release channel tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants