Build selected build-target when starting to debug #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddimax
force-pushed
the
build-target
branch
from
1b37614 to
77a0bd4
Compare
|
@microsoft-github-policy-service agree |
Maddimax
force-pushed
the
build-target
branch
from
77a0bd4 to
2b7f68d
Compare
src/cmakeProject.ts
Outdated
| const buildResult = await this.build([chosen.name]); | ||
| const defaultBuildTargets = await this.getDefaultBuildTargets(); | ||
| const allTargetsToBuild = new Set(defaultBuildTargets); | ||
| allTargetsToBuild.add(chosen.name); |
There was a problem hiding this comment.
Check if the defaultBuildTargets is equal to allTargetName. In that case, don't add the chosen.name to the list of targets.
There was a problem hiding this comment.
No, you should check if the set contains this.allTargetName. If that's the case, then you don't need to add the debug target to the list.
There was a problem hiding this comment.
use this.allTargetName instead of all
Maddimax
force-pushed
the
build-target
branch
from
2b7f68d to
b8eaec2
Compare
Maddimax
force-pushed
the
build-target
branch
from
b8eaec2 to
dfaf8f7
Compare
elahehrashedi
approved these changes
Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes visible behavior
The following changes are proposed:
The purpose of this change
For some projects, you always want to build ALL. This allows to set ALL as the build target, but still launch the selected launch target.