Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a setting to disable reading compile_commands.json for higher performance experience #2609

Merged
merged 6 commits into from
Sep 6, 2022
Merged

Add a setting to disable reading compile_commands.json for higher performance experience #2609

merged 6 commits into from
Sep 6, 2022

Conversation

xiaoyun94
Copy link
Contributor

This change addresses item #2586

This changes performance

The following changes are proposed:

The purpose of this change

  • Sacrifice some features for a higher performance experience.

@ghost
Copy link

ghost commented Jun 20, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@xiaoyun94 xiaoyun94 mentioned this pull request Jun 20, 2022
Closed
@xiaoyun94 xiaoyun94 closed this Jun 20, 2022
@xiaoyun94 xiaoyun94 reopened this Jun 20, 2022
elahehrashedi
elahehrashedi suggested changes Jul 6, 2022
View reviewed changes
i18n/chs/package.i18n.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
src/cmakeTools.ts Outdated Show resolved Hide resolved
@xiaoyun94 xiaoyun94 requested a review from elahehrashedi July 11, 2022 15:05
elahehrashedi
elahehrashedi previously requested changes Jul 12, 2022
View reviewed changes
package.nls.json Outdated Show resolved Hide resolved
src/cmakeTools.ts Outdated Show resolved Hide resolved
@xiaoyun94 xiaoyun94 requested a review from elahehrashedi July 16, 2022 08:03
@bobbrow
Copy link
Member

bobbrow commented Aug 15, 2022

Sorry for the silence on this. We will re-evaluate for 1.13 after 1.12 is published.

@bobbrow bobbrow added this to the On Deck milestone Aug 15, 2022
@bobbrow bobbrow enabled auto-merge (squash) September 2, 2022 21:02
@bobbrow bobbrow changed the title Support Omit Load Compile Command for Higher Performace Experience Add a setting to disable reading compile_commands.json for higher performance experience Sep 2, 2022
@bobbrow bobbrow disabled auto-merge September 2, 2022 21:06
@bobbrow bobbrow enabled auto-merge (squash) September 2, 2022 21:06
@bobbrow bobbrow disabled auto-merge September 6, 2022 18:17
@bobbrow bobbrow enabled auto-merge (squash) September 6, 2022 18:22
@bobbrow bobbrow disabled auto-merge September 6, 2022 19:04
@bobbrow bobbrow merged commit 5767a15 into microsoft:main Sep 6, 2022
@bobbrow bobbrow modified the milestones: On Deck, 1.13 Sep 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow approved these changes

@elahehrashedi elahehrashedi Awaiting requested review from elahehrashedi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoyun94 @bobbrow @elahehrashedi