Do not care about the bat call result #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
requested changes
Aug 21, 2020
lygstate
force-pushed
the
msvc-detect
branch
from
fb79b54 to
3f4ad63
Compare
|
ping |
lygstate
force-pushed
the
msvc-detect
branch
from
3f4ad63 to
b4a57ee
Compare
andreeis
reviewed
Oct 8, 2020
andreeis
reviewed
Oct 8, 2020
src/kit.ts
Outdated
| @@ -539,7 +540,8 @@ async function collectDevBatVars(devbat: string, args: string[], major_version: | |||
| try { | |||
| await fs.unlink(envpath); | |||
| } catch (error) {} | |||
| await fs.writeFile(batpath, bat.join('\r\n')); | |||
| const batContent = bat.join('\r\n'); | |||
There was a problem hiding this comment.
Minor: batContent can be set one line earlier, then fs.writeFile can use batContent as second parameter.
There was a problem hiding this comment.
Don't understand, batContent used latter
There was a problem hiding this comment.
I don't see it now but I thought I saw twice the following: bat.join('\r\n').
andreeis
reviewed
Oct 8, 2020
src/kit.ts
Outdated
Comment on lines
571
to
578
| if (vars.get('INCLUDE') === '') { | ||
| console.log(`Error running ${devbat} ${args.join(' ')}, cannot find INCLUDE`); | ||
| log.error(localize('script.run.error', 'Error running:\n{0}\nWith args:\n{1}, cannot find INCLUDE with {2}', batContent, args.join(' '), env)); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Not sure how readable that message is, because it has very long parts.
I'm thinking that we still need devbat in the message, as it were before, then being followed by the args. Right now, the args are coming after the devbat content.
Then, printing batContent and env is still useful, but part of a different message phrase.
lygstate
force-pushed
the
msvc-detect
branch
2 times, most recently
from
313f500 to
ae2d9f1
Compare
Thirdparty software would cause call "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\vcvarsall.bat" x86 to be called but with error code and the env are still set properly. The following are the execute result: ``` configuration might not be installed. C:\Users\大乖>call "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\vcvarsall.bat" x86 'MySQL' 不是内部或外部命令，也不是可运行的程序 或批处理文件。 'MySQL' 不是内部或外部命令，也不是可运行的程序 或批处理文件。 ```
andreeis
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thirdparty software would cause
call "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\vcvarsall.bat" x86
to be called but with error code
and the env are still set properly.
The following are the execute result:
This change addresses item #[[put issue number here to generate a link]]
This changes [[visible behavior/performance/documentation/etc.]]
The following changes are proposed:
The purpose of this change
Other Notes/Information