add API method for getActiveFolderPath #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcmorran
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Can you also change Version to include a new value for 1.1.* and make sure the logic in getCMakeToolsApi() handles it correctly? We need a way for API consumers to express the fact that they require the 1.1.* version instead of any 1.*.* version, which might not have the getActiveFolderPath() call that they need.
benmcmorran
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.
Add an api method for
getActiveFolderPathwhich returns a string representing the active workspace folder.Updates the minor version of the version number because this adds non-breaking features.