Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Added exception handlers for React Native Hermes debugging #548

Merged

Conversation

RedMickey
Copy link
Contributor

#517
The goal of this PR is to fix debugging of React Native Hermes applications via React Native Tools extension.
The table below contains the fixes descriptions:

Problem Before the fixes After the fixes Description
The debugger doesn’t show value of numeric variables (Problem №2 - Hermes known issues) Screen Shot 2019-12-25 at 13 38 33 Screen Shot 2019-12-25 at 13 32 20 Added the special condition to handle the case if there isn't description field in a RemoteObject. See getRemoteObjectPreview_primitive method.
The debugger doesn’t show arrays' content (Problem №5 - Hermes known issues) Screen Shot 2019-12-25 at 13 37 40 Screen Shot 2019-12-25 at 13 35 53 Added the handler in case of Runtime.callFunctionOn method returns an empty object. See getNumPropsByEval method.
The debugger doesn’t show functions' content(Problem №1, 4 - Hermes known issues) Screen Shot 2019-12-25 at 13 39 33 Screen Shot 2019-12-25 at 13 33 56 Added the handler in case of RemoteObject with function data doesn't contain description field. See createFunctionVariable method.

For reference: the list of known issues with Hermes debugging for React Native Tools extension.

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit ce24877 into microsoft:master Jan 2, 2020
@SounD120
Copy link
Contributor

Hi @roblourens . Do you know when this fix will be published in a new chrome-debug-core release? Thanks.

@roblourens
Copy link
Member

I have published an update, sorry I meant to do it earlier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants