Remove all usage of /m flag #482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
suggested changes
Apr 18, 2019
There was a problem hiding this comment.
So we don't want this change based off master or going into master. We want to create a hot fix release of the ui package based on the version last shipped with our extensions.
- The last release of App Service used 0.20.4 https://github.com/Microsoft/vscode-azureappservice/blob/v0.13.0/package-lock.json#L9006
- The last release of ARM used 0.20.3 https://github.com/Microsoft/vscode-azurearmtools/blob/v0.5.0/package-lock.json#L9628
Based on that - you would create a new rel/0.20.5 branch based off of v0.20.4-ui. Talk to me offline if you need more help on how to create a hot-fix release.
| function getCallstack(error: { stack?: string }): string | undefined { | ||
| // tslint:disable-next-line: strict-boolean-expressions | ||
| const stack: string = error.stack || ''; | ||
| // temporarily disable for extension activation hotfix |
There was a problem hiding this comment.
nit: It's better to use /* */ comments so you get fewer changes
|
As per PR advice, closing this in favor of rel branch https://github.com/Microsoft/vscode-azuretools/tree/rel/0.20.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix for these issues:
microsoft/vscode-azureappservice#942
microsoft/vscode-azurearmtools#206
I wanted to leave them commented in so it'd be easy to reimplement later, but I'm opened to just removing the code.
It's based off this release e727f16 which both Azure App Service and ARM are using.