Parse html errors #360
Merged
Parse html errors #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,7 @@ | |||
| "azure-arm-resource": "^3.0.0-preview", | |||
| "azure-arm-storage": "^3.1.0", | |||
| "fs-extra": "^4.0.3", | |||
| "html-to-text": "^4.0.0", | |||
There was a problem hiding this comment.
I feel this should be locked down, without the ^. There's quite some test code that essentially tests this package's functionality (rather than how we use it). A package update making our code fail (if the parseIfHtml behavior changes subtly) is more overhead, especially for this upstream repo which can break the downstream extensions.
There was a problem hiding this comment.
That's what the package-lock.json is for
nturinski
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test cases for example errors and what they look like now.
Fixes microsoft/vscode-azurefunctions#841
Related microsoft/vscode-azurefunctions#878