utils: Add an option to automatically select an AzureSubscription by subscriptionId
#1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
force-pushed
the
mwf/select-subscription-by-id
branch
from
c51b570 to
6726afb
Compare
| @@ -30,6 +34,14 @@ export class QuickPickAzureSubscriptionStep extends GenericQuickPickStepWithComm | |||
|
|
|||
| return pickedSubscription; | |||
| } | |||
|
|
|||
| protected override getPickWithoutPrompt(picks: IAzureQuickPickItem<SubscriptionItem>[]): IAzureQuickPickItem<SubscriptionItem> | undefined { | |||
There was a problem hiding this comment.
Instead of this implementation I'd try to do a skip-if-one step with pick filters that select only the chosen subscription.
MicroFish91
force-pushed
the
mwf/select-subscription-by-id
branch
from
1697bb1 to
6726afb
Compare
bwateratmsft
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to eventually use here: microsoft/vscode-azurecontainerapps#578
Wanted to add the ability to pass an option to
subscriptionExperienceto automatically select bysubscriptionIdwithout having to re-prompt the user.Example: