eslint-config: Enforce import types with @typescript-eslint/consistent-type-imports
#1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can it be configured so it applies not to internal imports but only to package imports? |
I haven't been able to find a way to make this distinction, but if anyone knows of a way please let me know |
|
It looks like as long as TS 4.5+ is in use, you can have it fix imports to look like this which IMO is neater: import { type Foo } from 'bar'; |
bwateratmsft
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does everyone feel about just adding this as an eslint rule so we don't have to think about whether something should be imported as a type or a value for optimization?
This should make it easier to enforce import types where we can essentially just run
eslint --fixRelated: microsoft/vscode-azurecontainerapps#568