Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut to switching to sovereign cloud within the tenant view #926

Open
wants to merge 2 commits into
base: meganmott/tenantView
Choose a base branch
from

Conversation

motm32
Copy link
Contributor

@motm32 motm32 commented Sep 17, 2024

This allows users to quickly change their sovereign cloud setting without having to go into the user settings.

The shortcut lives here under the gear icon:
image

There is also a command palette command titiled: Azure: Configure Sovereign Cloud

This brings up the below quick pick. The names correspond with the names on the setting. When an item is selected the setting microsoft-sovereign-cloud.environment is changed to the corresponding value.

(I included the generic azure one so user could switch back easily)

image

I tested this by switching between an Azure China account and a default Azure account and had no issues.

@motm32 motm32 requested a review from a team as a code owner September 17, 2024 22:34
@alexweininger
Copy link
Member

alexweininger commented Sep 17, 2024

Can you put a screenshot of the quick pick please

@motm32
Copy link
Contributor Author

motm32 commented Sep 17, 2024

Can you put a screenshot of the quick pick please

Yup I'll edit the description to add that

@alexweininger
Copy link
Member

just some quick feedback: Maybe we can put (Default) in the description of the "Azure" normal option?

@motm32
Copy link
Contributor Author

motm32 commented Sep 18, 2024

just some quick feedback: Maybe we can put (Default) in the description of the "Azure" normal option?

Yup I'll do that!

@alexweininger
Copy link
Member

Also I think we'll merge this after we merge the tenant view PR. There might be other small features like this on top of the tenant view that we want to add.

@motm32
Copy link
Contributor Author

motm32 commented Sep 18, 2024

Also I think we'll merge this after we merge the tenant view PR. There might be other small features like this on top of the tenant view that we want to add.

Sounds good I'll change the branch to main before we merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants