Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Fix #133 - Azure Environment Selector (Resubmitted) #151

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

creativekinetix
Copy link

@creativekinetix creativekinetix commented Mar 31, 2020

Fix #133 - Azure Environment Selector (Resubmitted)

Resubmitting PR (previous PR #150 closed while I sorted things out).

I was able to update vscode-azureextensionui to v0.17.1 which is the version the fix for Azure Government was introduced. I coupled the update with my previous changes where the baseUri parameter is passed into LogicAppsManagementClient() and got to a 95% working solution.

I have tested changes on both Azure Commercial and Azure Government. The following are the results.

  • FIXED: Create Logic App command working for Azure Government
  • FIXED: Promote command working for Azure Government
  • FIXED: Enable, Disable commands working for Azure Government
  • FIXED: Delete command working for Azure Government
  • FIXED: Create Integration Account working for Azure Government
  • FIXED: Create Integration Account SubChildren (ie: Partners) for Azure Government
  • NEEDS TEST: Add Build Definition to Project
  • NEEDS TEST: Open in Monitoring View
  • ERROR: openInDesigner throws subscriptionId error. Using ms-rest.ServiceClientCredentials.signRequest() instead of the LogicAppsManagementClient.

@creativekinetix creativekinetix changed the title Fix #133 - Azure Environment Selector Fix #133 - Azure Environment Selector (Resubmitted) Mar 31, 2020
@joechung-msft joechung-msft self-requested a review April 1, 2020 11:12
@joechung-msft
Copy link
Contributor

joechung-msft commented Apr 15, 2020

@creativekinetix , just a heads up - I am busy doing some time-sensitive work (for BUILD) so it might take me some time to get back to this review. I will try to get back to this as soon as I can.

@creativekinetix
Copy link
Author

@joechung-msft, I appreciate the update. Let me know if there is anything I can do to help.

Copy link
Contributor

@joechung-msft joechung-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thank you so much for doing this!

There are "management.azure.com" URLs that should be replaced with the resource manager endpoint URL depending on the environment:

  • src/utils/logic-app/connectionReferenceUtils.ts
  • src/utils/logic-app/designerUtils.ts
  • src/utils/logic-app/monitoringViewUtils.ts

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main December 3, 2020 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Environment Selector
2 participants