This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Fix #133 - Azure Environment Selector (Resubmitted) #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #133 - Azure Environment Selector (Resubmitted)
Resubmitting PR (previous PR #150 closed while I sorted things out).
I was able to update
vscode-azureextensionui
to v0.17.1 which is the version the fix for Azure Government was introduced. I coupled the update with my previous changes where thebaseUri
parameter is passed intoLogicAppsManagementClient()
and got to a 95% working solution.I have tested changes on both Azure Commercial and Azure Government. The following are the results.
ms-rest.ServiceClientCredentials.signRequest()
instead of theLogicAppsManagementClient
.