Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Change command labels, remove entry point for Create new project..., add Create Function App from deploy #4042

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nturinski
Copy link
Member

@nturinski nturinski commented Mar 15, 2024

This changes the Functions UI a bit to match what we discussed offline and insights from user studies.

  • Go back to removing Create New Project.... Replace Create Function... with Create function locally... (Not sure what looks best in terms of casing)
    If you're unfamiliar, Create Function... handles the following scenarios:
  1. Local project exists? Add a new function template.
  2. Local project exists but it's not initialized for VS Code? Prompts user to initialize for VS Code.
  3. Local project doesn't exist? Create a new project and ask what function template user wants (option to skip)
  • Added two entry points to Create function locally.... One on the Functions node indicated by the Function + button. Another as a context menu action. I'm debating moving it to the local project node.
    image

  • Mentioned renaming Create Function... but also renamed Deploy to Function App in Azure... to Deploy function to Azure.... It makes more intuitive sense because your local project is being deployed to Azure, and we have to prompt for which app is being deployed to.
    image

By that logic, I've kept Deploy to Function App... the same in the Resources view though.
image

  • Added Create New Project... to workspace view if there's no project in the workspace. It actually does call azureFunctions.createNewProject because we know that we need to start from scratch. createFunction has to do some checks before it ultimately cancels and calls createNewProject so performance is slightly better to just call it directly.
    image

  • Removed Create Function App... option in the local workspace view

    • This was replaced with just Deploy function to Azure... which includes a + Create new function app option as a quick pick when we prompt for the app
  • Merged Create New Containerized Project... into Create function locally... and add it as a prompt at the beginning. It's annoying, but also a one-time cost to the user that can be easily entered through.

@nturinski nturinski requested a review from a team as a code owner March 15, 2024 19:32
@nturinski nturinski changed the title UX: Change command labels, remove entry point for Create new project..., add UX: Change command labels, remove entry point for Create new project..., add Create Function App from deploy Mar 15, 2024
@nturinski
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants