Make skip for now message more clear when there are no resources available #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
approved these changes
Mar 3, 2023
|
I feel like I wouldn't know I can click the new one because it doesn't seem actionable. I think "Skipped" is the main word confusing me because it's past tense What about:
|
|
...dang it, I didn't see this comment until now. I'll change this if we aren't able to resolve this properly by allowing users to create a new resource directly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3550
This is the old skip for now. The behavior is the same as before:
If no picks were found, the message is edited to reflect that and hopefully makes it more clear for users. Ideally, we could create these resources for the user here later, but this is more of a gapfixer.
