Fix Armory issues with snippets #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 28, 2024 13:55
StephenWeatherford
requested review from
jfleisher and
AbhitejJohn
as code owners
AbhitejJohn
approved these changes
Jul 1, 2024
| } | ||
| ], | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "variables": { | ||
| //Insert here: variable |
There was a problem hiding this comment.
Are these comments expected to be removed?
There was a problem hiding this comment.
Doesn't matter, they're testing artifacts and are removed before baseline comparison anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifted new VM snippets from our documentation, kept it simple by not having any tabstops or placeholders. In general they're going to want parameters for these types of things anyway.
For virtual networks, made fixes in situ. The rest is mostly testcase baseline updates.