Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andrsmith/add automanage snippets #1508

Merged
merged 9 commits into from
Sep 14, 2022
Merged

Andrsmith/add automanage snippets #1508

merged 9 commits into from
Sep 14, 2022

Conversation

The-DevBlog
Copy link
Contributor

Added:

  • Automanage Best Practices DevTest Assignment.snippet.json
  • Automanage Best Practices Prod Assignment.snippet.json
  • Automanage Custom Profile Assignment.snippet.json
  • Automanage Create Custom Profile.snippet.json

@The-DevBlog The-DevBlog mentioned this pull request Aug 29, 2022
Closed
@StephenWeatherford
Copy link
Contributor

Thanks, may take me a few days to get to this. Need to release the extension against soon.

@The-DevBlog
Copy link
Contributor Author

Sounds great @StephenWeatherford!

@StephenWeatherford
Copy link
Contributor

Running suites locally because they unfortunately don't all run for remote branches...

@StephenWeatherford
Copy link
Contributor

I need to update schemas...
image

@StephenWeatherford
Copy link
Contributor

After updating schemas, still missing 3 of the 4:
image

StephenWeatherford
StephenWeatherford requested changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments thx

@The-DevBlog The-DevBlog requested review from StephenWeatherford and removed request for alexgav and bhsubra September 14, 2022 21:02
StephenWeatherford
StephenWeatherford approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@StephenWeatherford StephenWeatherford merged commit 47b1e11 into microsoft:main Sep 14, 2022
@StephenWeatherford StephenWeatherford mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoore-msft bmoore-msft bmoore-msft left review comments

@StephenWeatherford StephenWeatherford StephenWeatherford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@The-DevBlog @StephenWeatherford @bmoore-msft @andrsmith149