Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added listAccountSas TLE #125

Merged
merged 3 commits into from
Aug 13, 2018
Merged

added listAccountSas TLE #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acbce42
added listAccountSas TLE
bmoore-msft Aug 6, 2018
6e3fd7d
revert/update resource param
bmoore-msft Aug 6, 2018
559c05a
Fix tests
Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion assets/ExpressionMetadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,18 @@
"minimumArguments": 2,
"maximumArguments": 2
},
{
"name": "listAccountSas",
"expectedUsage": "listAccountSas(resourceName\/resourceIdentifier, apiVersion, requestContent)",
"description": "Creates and returns a SAS token with the specified permissions and expiry from the requestContent. The requestContent object must contain the signedServices, signedResourceTypes, signedPermission and signedExpiry properties.",
"minimumArguments": 3,
"maximumArguments": 3,
"returnValueMembers": [
{
"name": "accountSasToken"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is correct. Does it return an object with a accountSasToken property (as you have here), or does it simply return the account SAS token? Thx.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns an object with exactly one property named accountSasToken

}
]
},
{
"name": "listKeys",
"expectedUsage": "listKeys(resourceName\/resourceIdentifier, apiVersion)",
Expand All @@ -261,7 +273,7 @@
},
{
"name": "listPackage",
"expectedUsage": "listPackage(resourceId, apiVersion)",
"expectedUsage": "listPackage(resourceName\/resourceIdentifier, apiVersion)",
"description": "Lists the virtual network gateway package. The resourceId can be specified by using the resourceId function or by using the format providerNamespace/resourceType/resourceName.",
"minimumArguments": 2,
"maximumArguments": 2
Expand Down
2 changes: 1 addition & 1 deletion test/AzureRMAssets.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ suite("AzureRMAssets", () => {
},
{
"name": "listPackage",
"expectedUsage": "listPackage(resourceId, apiVersion)",
"expectedUsage": "listPackage(resourceName\/resourceIdentifier, apiVersion)",
"minimumArguments": 2,
"maximumArguments": 2
},
Expand Down
2 changes: 1 addition & 1 deletion test/PositionContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ suite("PositionContext", () => {
}

function listPackageCompletion(startIndex: number, length: number): Completion.Item {
return new Completion.Item("listPackage", "listPackage($0)", new language.Span(startIndex, length), "(function) listPackage(resourceId, apiVersion)", "Lists the virtual network gateway package. The resourceId can be specified by using the resourceId function or by using the format providerNamespace/resourceType/resourceName.", Completion.CompletionKind.Function);
return new Completion.Item("listPackage", "listPackage($0)", new language.Span(startIndex, length), "(function) listPackage(resourceName\/resourceIdentifier, apiVersion)", "Lists the virtual network gateway package. The resourceId can be specified by using the resourceId function or by using the format providerNamespace/resourceType/resourceName.", Completion.CompletionKind.Function);
}

function modCompletion(startIndex: number, length: number): Completion.Item {
Expand Down