Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when using dotnet path override #1181

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Add warning when using dotnet path override #1181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/languageclient/startArmLanguageServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,11 @@ async function getDotNetPath(): Promise<string | undefined> {

const overriddenDotNetExePath = workspace.getConfiguration(configPrefix).get<string>(configKeys.dotnetExePath);
if (typeof overriddenDotNetExePath === "string" && !!overriddenDotNetExePath) {
ext.outputChannel.appendLine(
`WARNING: ${configPrefix}.${configKeys.dotnetExePath} is set. ` +
`This overrides the automatic download and usage of the dotnet runtime and should only be used to work around dotnet installation issues. ` +
`If you encounter problems, please try clearing this setting.`);
ext.outputChannel.appendLine("");
if (!(await isFile(overriddenDotNetExePath))) {
throw new Error(`Invalid path given for ${configPrefix}.${configKeys.dotnetExePath} setting. Must point to dotnet executable. Could not find file ${overriddenDotNetExePath}`);
}
Expand Down