Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update expression metadata for createArray/createObject #1052

Merged
merged 9 commits into from
Oct 14, 2020
Merged

update expression metadata for createArray/createObject #1052

merged 9 commits into from
Oct 14, 2020

Conversation

bmoore-msft
Copy link
Contributor

fix #1050

@StephenWeatherford StephenWeatherford changed the base branch from master to main October 14, 2020 18:46
@StephenWeatherford StephenWeatherford merged commit c46a5b2 into microsoft:main Oct 14, 2020
@brwilkinson
Copy link

Thanks @bmoore-msft ... next time I will attempt a fix myself... might reach out if I have questions along the way.

@StephenWeatherford
Copy link
Contributor

Feel free to question me as well.

@bmoore-msft bmoore-msft mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenWeatherford StephenWeatherford StephenWeatherford approved these changes

@alexgav alexgav Awaiting requested review from alexgav

@bhsubra bhsubra Awaiting requested review from bhsubra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createArray() now supports creating an empty array, update tooling to avoid false positive
3 participants
@bmoore-msft @brwilkinson @StephenWeatherford