Fails to create a parameter file for arm template when encoded with UTF-8 BOM

[kernst123]

Does this occur consistently? Yes
Repro steps:

1. from vs code create a new arm template (use snippet arm! )
2. from vs code select/create parameter file...
   I receive the error below

Action: azurerm-vscode-tools.selectParameterFile
Error type: Error
Error Message: "e:\temp\armtemp\mytemplate.json" does not appear to be an Azure Resource Manager deployment template file.

Version: 0.10.0
OS: win32
OS Release: 10.0.17763
Product: Visual Studio Code
Product Version: 1.45.1
Language: en

Call Stack

Object.<anonymous> extension.bundle.js:1:596601
fulfilled extension.bundle.js:1:593686

[StephenWeatherford]

@kernst123 Thanks for entering!

Was the file saved before doing step 2? If not, it's probably a duplicate of #666.

[kernst123]

Hi, Yes it was saved before I invoked the command. -- Kevin From: Stephen Weatherford (MSFT) <[email protected]> Sent: May 20, 2020 1:32 PM To: microsoft/vscode-azurearmtools <[email protected]> Cc: Kevin Ernst <[email protected]>; Mention <[email protected]> Subject: Re: [microsoft/vscode-azurearmtools] Fails to create a parameter file for arm template (#721) @kernst123<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kernst123&d=DwMCaQ&c=hmGTLOph1qd_VnCqj81HzEWkDaxmYdIWRBdoFggzhj8&r=B9i9u3ndn_TEKn0Byu-2yB9Tw3lp3fC37Jpl0Mm7Zxc&m=eqHQ0OXjj2Y7fAzCQW8OGHm57FgX5YrwptxT3KOb7NI&s=Y_uwsCabyEfAU4_TptLeWGqk5tSYoDLkESTW5GYnAR4&e=> Thanks for entering! Was the file saved before doing step 2? If not, it's probably a duplicate of #666<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_microsoft_vscode-2Dazurearmtools_issues_666&d=DwMCaQ&c=hmGTLOph1qd_VnCqj81HzEWkDaxmYdIWRBdoFggzhj8&r=B9i9u3ndn_TEKn0Byu-2yB9Tw3lp3fC37Jpl0Mm7Zxc&m=eqHQ0OXjj2Y7fAzCQW8OGHm57FgX5YrwptxT3KOb7NI&s=51dXuQGrK_WLyGtlON0sXTGCRWU5Hx_2tJ6v0ONHNJM&e=>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_microsoft_vscode-2Dazurearmtools_issues_721-23issuecomment-2D631618321&d=DwMCaQ&c=hmGTLOph1qd_VnCqj81HzEWkDaxmYdIWRBdoFggzhj8&r=B9i9u3ndn_TEKn0Byu-2yB9Tw3lp3fC37Jpl0Mm7Zxc&m=eqHQ0OXjj2Y7fAzCQW8OGHm57FgX5YrwptxT3KOb7NI&s=Yq37ZantM5vjSfwFHV-isu0hk2TducdwbAOBqZqdKsg&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJVHGH2C4T2PPG4PI4E3W7DRSQHXZANCNFSM4NF3WZUA&d=DwMCaQ&c=hmGTLOph1qd_VnCqj81HzEWkDaxmYdIWRBdoFggzhj8&r=B9i9u3ndn_TEKn0Byu-2yB9Tw3lp3fC37Jpl0Mm7Zxc&m=eqHQ0OXjj2Y7fAzCQW8OGHm57FgX5YrwptxT3KOb7NI&s=qBQQU98HLLeHIslq_OlBRakUOwr83oePVpvgj5hU9as&e=>.

[StephenWeatherford]

@neilpeterson This looks vaguely familiar but I can't find any dups. Have you seen this behavior? Thx.

[neilpeterson]

@StephenWeatherford nope this appears to be unique as compared to similar open items.

I was however able to reproduce the error / call stack by trying to create a parameters file from an invalid ARM template (removed the opening bracket).

@kernst123 can you share the ARM template that you using when attempting to create the parameter file?

Thanks

[kernst123]

Here is an example of the arm template it failed for.
I blanked out the tenant-id and the objectID so you will nee to put something relevant in for that.
My original version I did infact run and it created the key vault just to confirm that it is valid.
I hope this helps.

[kernst123]

Hmmm I thought I posted a zip file. I don't see it above. I will try again.
test.json.zip

[neilpeterson]

Thanks @kernst123, I noticed that both tenant and object id did have values so removed the file from the issue.

I am looking at it now, but unfortunately cannot reproduce the issue. I am able to create the parameter file without issue using the provided tempalte.

[kernst123]

Hmm it's a tricky one.
Here is a screenshot showing the error.

Is there any logging I could enable on my end?
Or any version info that might be relevant that I could show you?

[StephenWeatherford]

I can repro with the attached, thanks (not sure why Neil can't). We're having trouble with the UTF-8 BOM (the one on disk, not the text buffer).

[neilpeterson]

Ahhh, works fine on my Mac but does repo in Windows.

[StephenWeatherford]

Weird, I repro'd it with my Mac.

[kernst123]

As soon as I changed the encoding from utf8 bom to utf8 it started working.
thanks.
I changed vscode's default to utf8 from the old value utf8 bom.

[StephenWeatherford]

Fix released with 0.11.0