Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM template user defined functions are not supported #122

Closed
Bassicaly opened this issue Jul 18, 2018 · 16 comments
Closed

ARM template user defined functions are not supported #122

Bassicaly opened this issue Jul 18, 2018 · 16 comments

Comments

@Bassicaly
Copy link

VSCode does not yet support ARM templates as definded here:

https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-authoring-templates#functions

Please could this be implemented?

@fiveisprime
Copy link
Member

Talked with an Ignite attendee who has run into this as well, here's his blog about how he's using functions and an example arm template that we could use to test this.

https://azurekid.blog/2018/06/17/arm-templates-and-azure-governance/
https://github.com/azurekid/blog/blob/master/virtualMachine.json

@Bassicaly
Copy link
Author

Bassicaly commented Sep 27, 2018 via email

@Tadimsky
Copy link

This would be awesome.
It'd be really nice to have it show no more errors for our deployments :)

image

@StephenWeatherford
Copy link
Contributor

Thanks for the feedback. We still have to prioritize, so it's helpful to know how many people this would help.

@StephenWeatherford StephenWeatherford added this to the 0.6.0 milestone Feb 23, 2019
@riangiddings
Copy link

+1 for this fix, look forward to having this feature implemented!

@StephenWeatherford StephenWeatherford modified the milestones: 0.6.0, 0.7.0 Apr 16, 2019
@StephenWeatherford
Copy link
Contributor

Good to know, thanks!

@StephenWeatherford StephenWeatherford modified the milestones: 0.6.0, 0.7.0 Apr 22, 2019
@lwajswaj
Copy link

lwajswaj commented May 3, 2019

+1; errors are also misleading as parameters consumed by the function are marked as missing as the extension confuses them template parameters

@ggirard07
Copy link

+1 too... having an error reported each time we use a function from a local namespace actually hide real error(s) on the same line

@Apholisha
Copy link

+1

@azurekid
Copy link

Shamelessly promoting my blog about user defined functions. Hopefully it inspires more to use it.
https://azurekid.blog/2019/07/09/standardize-arm-templates

@StephenWeatherford
Copy link
Contributor

@azurekid :-) Their usage appears to be somewhat low right now, but I agree they ought to be used more.

@twids
Copy link

twids commented Aug 23, 2019

+1. I think the biggest "issue" is that it is marked as errors in the file..
Parameter handling and stuff could be added "later" but removing the incorrect errors would be very appreciated

@StephenWeatherford
Copy link
Contributor

Okay, thanks. This is pretty high on the list now.

@StephenWeatherford
Copy link
Contributor

I considered whether there was a way to just get rid of the false errors in a quick manner, but I think it's too complicated for that - for instance, we user-defined functions, you can have parameters defined in a scope not at the top level, which we don't understand yet. About to start working on this, so hopefully in the next release (after the one about to ship). Thanks for your patience.

@StephenWeatherford
Copy link
Contributor

In progress...

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
@neilpeterson
Copy link
Contributor

Fix went out today with this fix, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests