Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for pickZones function #1130

Closed
bgold09 opened this issue Dec 18, 2020 · 6 comments
Closed

Support for pickZones function #1130

bgold09 opened this issue Dec 18, 2020 · 6 comments
Assignees
@StephenWeatherford
Labels
bug extension fix released P1
Milestone
0.14.1

Comments

@bgold09
Copy link
Member

bgold09 commented Dec 18, 2020

The extension currently does not recognize the pickZones() function, resulting in false positives for syntax errors as well as missing Intellisense.
@StephenWeatherford
Copy link
Contributor

@bgold09 Thanks for letting us know! I'm currently out of office, but can get to this early next year. Feel free to submit a PR for it yourself in https://github.com/microsoft/vscode-azurearmtools/blob/main/assets/ExpressionMetadata.json.

@bgold09 bgold09 mentioned this issue Dec 23, 2020
Merged
@StephenWeatherford StephenWeatherford self-assigned this Jan 6, 2021
@StephenWeatherford StephenWeatherford added this to the 0.14.5 milestone Jan 6, 2021
StephenWeatherford pushed a commit that referenced this issue Jan 6, 2021
@bgold09
Add support for pickZones() function (#1132)
84342da 
* Add support for pickZones() function

* Addresses #1130

* undo changes to test files
@StephenWeatherford
Copy link
Contributor

@bgold09 Thanks! Would you like access to an alpha version with the fix?

@bgold09
Copy link
Member Author

bgold09 commented Jan 8, 2021

That's alright, happy to wait for the normal release. Is there a regular release cadence?

@StephenWeatherford
Copy link
Contributor

Not scheduled, no, but would like to do a point release soon (next week or two). The next major release is several weeks away. Will let you know when it comes out.

@StephenWeatherford
Copy link
Contributor

@bgold09 This was just released, thanks again for your contribution! Had intended to release earlier but got blocked by some schema regressions.

@bgold09
Copy link
Member Author

bgold09 commented Feb 5, 2021

No worries, I just updated to the latest version and it all works 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenWeatherford StephenWeatherford

Labels
bug extension fix released P1
Projects
None yet
Milestone
0.14.1
Development

No branches or pull requests
2 participants
@bgold09 @StephenWeatherford