add svg icons for loadbalancer, virtual machine scaleset, and service…

… fabric resources. (#1255) * add service fabric svg * add service fabric svg * add loadbalancer svg * add vmss svg * add svg icons for loadbalancer, virtual machine scaleset, and service fabric resources * fix test getIcon: display correct icon
microsoft · Mar 15, 2021 · b2458ef · b2458ef
1 parent 61ba4b9
commit b2458ef
Show file tree

Hide file tree

Showing 6 changed files with 68 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 All notable changes to the "vscode-azurearmtools" extension will be documented in this file.
 
+## Version 0.16.0 (2021--)
+
+### Added
+
+- Svg icons for loadbalancer, virtual machine scaleset, and service fabric resources.
+
 ## Version 0.15.0 (2021-03-08)
 
 ### Added

diff --git a/icons/loadbalancers.svg b/icons/loadbalancers.svg
diff --git a/icons/servicefabric.svg b/icons/servicefabric.svg
diff --git a/icons/virtualmachinescalesets.svg b/icons/virtualmachinescalesets.svg
diff --git a/src/vscodeIntegration/Treeview.ts b/src/vscodeIntegration/Treeview.ts
@@ -62,6 +62,7 @@ const resourceIcons: [string, string][] = [
     ["Microsoft.Automation/automationAccounts/webhooks", "automation.svg"],
     ["Microsoft.Cdn/profiles", "cdnprofiles.svg"],
     ["Microsoft.Compute/virtualMachines", "virtualmachines.svg"],
+    ["Microsoft.Compute/virtualMachineScaleSets", "virtualmachinescalesets.svg"],
     ["Microsoft.Compute/virtualMachines/extensions", "extensions.svg"],
     ["Microsoft.ContainerInstance/containerGroups", "containerinstances.svg"],
     ["Microsoft.DocumentDB/databaseAccounts", "cosmosdb.svg"],
@@ -100,6 +101,7 @@ const resourceIcons: [string, string][] = [
     ["Microsoft.KeyVault/vaults/secrets", "keyvaults.svg"],
     ["Microsoft.Media/mediaServices", "mediaservices.svg"],
     ["Microsoft.Network/azureFirewalls", "firewall.svg"],
+    ["Microsoft.Network/loadBalancers", "loadbalancers.svg"],
     ["Microsoft.Network/networkInterfaces", "nic.svg"],
     ["Microsoft.Network/networkSecurityGroups", "nsg.svg"],
     ["Microsoft.Network/networkSecurityGroups/securityRules", "nsg.svg"],
@@ -109,6 +111,7 @@ const resourceIcons: [string, string][] = [
     ["Microsoft.Network/trafficManagerProfiles", "trafficmanagerprofiles.svg"],
     ["Microsoft.Network/virtualNetworkGateways", "virtualnetworkgateways.svg"],
     ["Microsoft.Network/virtualNetworks", "virtualnetworks.svg"],
+    ["Microsoft.ServiceFabric/clusters", "servicefabric.svg"],
     ["Microsoft.Sql/instancePools", "sqlservers.svg"],
     ["Microsoft.Sql/locations/instanceFailoverGroups", "sqlservers.svg"],
     ["Microsoft.Sql/managedInstances", "sqlservers.svg"],

diff --git a/test/Treeview.test.ts b/test/Treeview.test.ts
@@ -298,6 +298,9 @@ suite("TreeView", async (): Promise<void> => {
                         {
                             "type": "Microsoft.Compute/virtualMachines/extensions"
                         },
+                        {
+                            "type": "Microsoft.Compute/virtualMachineScaleSets"
+                        },
                         {
                             "type": "Microsoft.ContainerInstance/containerGroups"
                         },
@@ -409,6 +412,9 @@ suite("TreeView", async (): Promise<void> => {
                         {
                             "type": "Microsoft.Network/azureFirewalls"
                         },
+                        {
+                            "type": "Microsoft.Network/loadBalancers"
+                        },
                         {
                             "type": "Microsoft.Network/networkInterfaces"
                         },
@@ -436,6 +442,9 @@ suite("TreeView", async (): Promise<void> => {
                         {
                             "type": "Microsoft.Network/virtualNetworks"
                         },
+                        {
+                            "type": "Microsoft.ServiceFabric/clusters"
+                        },
                         {
                             "type": "Microsoft.Sql/instancePools"
                         },
@@ -703,6 +712,7 @@ suite("TreeView", async (): Promise<void> => {
                         getIconObject("cdnprofiles.svg", undefined),
                         getIconObject("virtualmachines.svg", undefined),
                         getIconObject("extensions.svg", undefined),
+                        getIconObject("virtualmachinescalesets.svg", undefined),
                         getIconObject("containerinstances.svg", undefined),
                         getIconObject("cosmosdb.svg", undefined),
                         getIconObject("cosmosdb.svg", undefined),
@@ -740,6 +750,7 @@ suite("TreeView", async (): Promise<void> => {
                         getIconObject("keyvaults.svg", undefined),
                         getIconObject("mediaservices.svg", undefined),
                         getIconObject("firewall.svg", undefined),
+                        getIconObject("loadbalancers.svg", undefined),
                         getIconObject("nic.svg", undefined),
                         getIconObject("nsg.svg", undefined),
                         getIconObject("nsg.svg", undefined),
@@ -749,6 +760,7 @@ suite("TreeView", async (): Promise<void> => {
                         getIconObject("trafficmanagerprofiles.svg", undefined),
                         getIconObject("virtualnetworkgateways.svg", undefined),
                         getIconObject("virtualnetworks.svg", undefined),
+                        getIconObject("servicefabric.svg", undefined),
                         getIconObject("sqlservers.svg", undefined),
                         getIconObject("sqlservers.svg", undefined),
                         getIconObject("sqlservers.svg", undefined),