Fix some lint (#75)

src/Hover.ts

@@ -2,6 +2,8 @@
 // Copyright (c) Microsoft Corporation.  All rights reserved.
 // ----------------------------------------------------------------------------
 
+// tslint:disable max-classes-per-file // Grandfathered in
+
 import * as language from "./Language";
 
 /**
@@ -59,4 +61,4 @@ export class VariableReferenceInfo extends Info {
     public getHoverText(): string {
         return `**${this._name}** (variable)`;
     }
-}
+}

src/JSON.ts

@@ -2,6 +2,9 @@
 // Copyright (c) Microsoft Corporation.  All rights reserved.
 // ----------------------------------------------------------------------------
 
+// tslint:disable switch-default // Grandfathered in
+// tslint:disable max-classes-per-file // Grandfathered in
+
 import * as assert from "assert";
 
 import * as basic from "./Tokenizer";
@@ -555,7 +558,7 @@ export class ObjectValue extends Value {
     }
 
     /**
-     * Get the property names 
+     * Get the property names
      */
     public get propertyNames(): string[] {
         return Object.keys(this.propertyMap);
@@ -1096,4 +1099,4 @@ export abstract class Visitor {
 
     public visitNullValue(nullValue: NullValue): void {
     }
-}
+}

src/TLE.ts

@@ -4,6 +4,9 @@
 
 // TLE = Template Language Expression
 
+// tslint:disable:switch-default // Grandfathered in
+// tslint:disable max-classes-per-file // Grandfathered in
+
 import * as assert from "assert";
 
 import * as assets from "./AzureRMAssets";

src/Telemetry.ts

@@ -2,6 +2,8 @@
 // Copyright (c) Microsoft Corporation.  All rights reserved.
 // ----------------------------------------------------------------------------
 
+// tslint:disable max-classes-per-file // Grandfathered in
+
 import * as appInsights from "applicationinsights";
 import * as assert from "assert";
 import * as fs from "fs";
@@ -136,7 +138,7 @@ export class VSCode extends Endpoint {
         if (reporter) {
             let properties: { [key: string]: string } = undefined;
             let measurements: { [key: string]: number } = undefined;
-    
+
             for (let propertyName in event) {
                 if (propertyName !== "eventName") {
                     let propertyValue = event[propertyName];
@@ -157,7 +159,7 @@ export class VSCode extends Endpoint {
 
             reporter.sendTelemetryEvent(event.eventName, properties, measurements);
         }
-    }        
+    }
 }
 
 /**
@@ -256,4 +258,4 @@ export class List extends Endpoint {
             endpoint.close();
         }
     }
-}
+}

src/Treeview.ts

@@ -1,3 +1,10 @@
+// ----------------------------------------------------------------------------
+// Copyright (c) Microsoft Corporation.  All rights reserved.
+// ----------------------------------------------------------------------------
+
+// tslint:disable:no-var-keyword // Grandfathered in
+// tslint:disable:no-duplicate-variable // Grandfathered in
+
 import * as Json from "./JSON";
 import * as vscode from "vscode";
 import { TreeItem } from "vscode";

src/VSCodeTelReporter.ts

@@ -6,7 +6,7 @@
 import TelemetryReporter from 'vscode-extension-telemetry';
 import * as vscode from 'vscode';
 
-export var reporter: TelemetryReporter;
+export let reporter: TelemetryReporter;
 
 export class Reporter extends vscode.Disposable {
     constructor(ctx: vscode.ExtensionContext) {
@@ -26,6 +26,7 @@ interface IPackageInfo {
 }
 
 function getPackageInfo(context: vscode.ExtensionContext): IPackageInfo | undefined {
+    // tslint:disable-next-line:non-literal-require
     let extensionPackage = require(context.asAbsolutePath('./package.json'));
     if (extensionPackage) {
         return {

test/SurveyMetadata.test.ts

@@ -7,6 +7,7 @@ import * as assert from "assert";
 import { SurveyMetadata } from "../src/SurveyMetadata";
 import { SurveySettings } from "../src/SurveySettings";
 
+// tslint:disable-next-line:no-suspicious-comment
 // TODO: Re-enable as part of https://github.com/Microsoft/vscode-azurearmtools/issues/51
 function suiteDisabled(name: string, func: Function) {
 }

test/SurveySettings.test.ts

@@ -6,6 +6,7 @@ import * as assert from "assert";
 
 import { SurveySettings } from "../src/SurveySettings";
 
+// tslint:disable-next-line:no-suspicious-comment
 // TODO: Re-enable as part of https://github.com/Microsoft/vscode-azurearmtools/issues/51
 function suiteDisabled(name: string, func: Function) {
 }

tslint.json

@@ -21,7 +21,7 @@
         "no-string-based-set-immediate": true,
         "no-string-based-set-interval": true,
         "no-string-based-set-timeout": true,
-        // TODO: "non-literal-require": true,
+        "non-literal-require": true,
         "possible-timing-attack": true,
         "react-anchor-blank-noopener": true,
         "react-iframe-missing-sandbox": true,
@@ -54,7 +54,7 @@
         "no-debugger": true,
         "no-duplicate-switch-case": true,
         "no-duplicate-super": true,
-        // TODO: "no-duplicate-variable": true,
+        "no-duplicate-variable": true,
         // TODO: "no-empty": true,
         "no-floating-promises": true,
         // TODO: "no-for-in-array": true,
@@ -93,14 +93,13 @@
             "allow-undefined-union", // changed
             "allow-mix" // changed
         ],
-        // TODO: "switch-default": true,
+        "switch-default": true,
         "triple-equals": [
             false, // TODO: true,
             "allow-null-check"
         ],
         "use-isnan": true,
         "use-named-parameter": true,
-        "typeof-compare": true,
         "adjacent-overload-signatures": true,
         "array-type": [
             true,
@@ -122,7 +121,7 @@
         // TODO: "interface-name": true,
         "jsdoc-format": true,
         "max-classes-per-file": [
-            false, // TODO: true,
+            true,
             3
         ],
         "max-file-line-count": true,
@@ -159,14 +158,14 @@
         "no-relative-imports": false, // changed
         "no-require-imports": false, // changed
         //TODO: "no-shadowed-variable": true,
-        // TODO: "no-suspicious-comment": true,
+        "no-suspicious-comment": true,
         "no-typeof-undefined": true,
         "no-unnecessary-field-initialization": true,
         // TODO: "no-unnecessary-local-variable": true,
         "no-unnecessary-qualifier": true,
         "no-unsupported-browser-code": true,
         "no-useless-files": true,
-        // TODO: "no-var-keyword": true,
+        "no-var-keyword": true,
         // TODO: "no-var-requires": true,
         // TODO: "no-var-self": true,
         "no-void-expression": [