Fix tests part 1 (#1705)

* Fix tests

* Requires node 16 or higher

* Hopefully fix test issues on windows

* fix spaces in folder for tests

.azure-pipelines/common/build.yml

@@ -7,7 +7,7 @@ steps:
   - task: NodeTool@0
     displayName: "Install node.js"
     inputs:
-      versionSpec: 14.21.3
+      versionSpec: 18
 
   - script: npm install -g [email protected]
     displayName: "Install npm"

.vscode/settings.json

@@ -9,8 +9,8 @@
         "**/node_modules": true
     },
     "editor.codeActionsOnSave": {
-        "source.fixAll": true,
-        "source.organizeImports": true
+        "source.fixAll": "explicit",
+        "source.organizeImports": "explicit"
     },
     "files.exclude": {
         "**/.git": true,

gulpfile.ts

@@ -5,6 +5,7 @@
 
 // tslint:disable:no-unsafe-any no-console prefer-template no-implicit-dependencies export-name
 
+import { downloadAndUnzipVSCode, resolveCliArgsFromVSCodeExecutablePath } from '@vscode/test-electron';
 import * as assert from 'assert';
 import * as cp from 'child_process';
 import * as fse from 'fs-extra';
@@ -15,7 +16,6 @@ import * as process from 'process';
 import * as recursiveReadDir from 'recursive-readdir';
 import * as shelljs from 'shelljs';
 import { gulp_webpack } from 'vscode-azureextensiondev';
-import { downloadAndUnzipVSCode, resolveCliPathFromVSCodeExecutablePath } from "vscode-test";
 import { DEFAULT_TESTCASE_TIMEOUT_MS, langServerDotnetVersion, languageServerFolderName } from './common';
 import { getTempFilePath } from './test/support/getTempFilePath';
 
@@ -94,23 +94,43 @@ async function test(): Promise<void> {
     console.log("");
 
     const vscodeExecutablePath = await downloadAndUnzipVSCode();
-    const cliPath = resolveCliPathFromVSCodeExecutablePath(vscodeExecutablePath);
+    const [cliRawPath, ...cliArguments] =
+      resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
+    const cliPath = `"${cliRawPath}"`;
 
     const extensionInstallArguments = [
+        ...cliArguments,
         "--install-extension",
         "ms-dotnettools.vscode-dotnet-runtime",
     ];
 
-    // Install .NET Install Tool as a dependency.
+      // Install .NET Install Tool extension as a dependency.
+      console.log(
+        `Installing dotnet extension: ${cliPath} ${extensionInstallArguments.join(" ")}`,
+      );
     let result = cp.spawnSync(cliPath, extensionInstallArguments, {
         encoding: "utf-8",
         stdio: "inherit",
+        shell: true,
     });
     if (result.status !== 0) {
-        throw new Error("Failed to install dotnet runtime extension");
+        throw new Error("Failed to install dotnet runtime extension: " + result.error ?? result.output?.filter((o) => !!o).join("\n") ?? "Unknown error");
+    }
+    console.log("Installed extensions:");
+    result = cp.spawnSync(cliPath, [
+        ...cliArguments,
+        "--list-extensions",
+      ], {
+      encoding: "utf-8",
+      stdio: "inherit",
+      shell: true,
+    });
+    console.log(result.error ?? result.output?.filter((o) => !!o).join("\n"));
+    if (result.error) {
+      process.exit(1);
     }
 
-    result = cp.spawnSync('node', ['./out/test/runTest.js'], { encoding: "utf-8", stdio: 'inherit', env });
+    result = cp.spawnSync('node', ['./out/test/runTest.js'], { encoding: "utf-8", stdio: 'inherit', env, shell: true });
     if (result.status !== 0) {
         throw new Error("Tests failed");
     }