Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to deploy zip files directly #2621

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Allow users to deploy zip files directly #2621

merged 2 commits into from
Feb 13, 2024

Conversation

nturinski
Copy link
Member

@nturinski nturinski commented Feb 9, 2024

Tested it with a zip file and it seems like it works perfectly fine.

How to test:

  1. Clone a sample project (this one works fine https://github.com/johnpapa/node-hello)
  2. Zip its contents (make sure that you don't zip the folder itself)
  3. Right-click and deploy

@nturinski nturinski requested a review from a team as a code owner February 9, 2024 19:24
alexweininger
alexweininger previously approved these changes Feb 12, 2024
Copy link
Member

@alexweininger alexweininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test case for this

MicroFish91
MicroFish91 previously approved these changes Feb 12, 2024
@nturinski
Copy link
Member Author

Can't actually test this right now due to tests being skipped, but I think that this should work

@nturinski nturinski merged commit 0351797 into main Feb 13, 2024
5 checks passed
@nturinski nturinski deleted the nat/zipfileDeploy branch February 13, 2024 18:01
@microsoft microsoft locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants