Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workspace based app insights #2619

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Create workspace based app insights #2619

merged 2 commits into from
Feb 12, 2024

Conversation

nturinski
Copy link
Member

@nturinski nturinski commented Feb 9, 2024

Leverages log analytics create step, which is required to migrate App Insights to the Workspace Based. Here is some documentation on that. This was already being done in Functions, so the step already existed.

It also uses the connection string property rather than the instrumentational key since that is the recommended path going forward.

Another reference: https://learn.microsoft.com/en-us/azure/azure-monitor/app/create-workspace-resource

How to test:

  1. Right-click "App Service" node and select "Create Web App..."
  2. Fill out the prompts
  3. Check to see if a log analytics workspace is created and linked to app insights
  4. Check in the portal for the app insight component and make sure it's workspace-based (it'll tell you that you need to migrate it)
  5. Try it with advanced too

@nturinski nturinski requested a review from a team as a code owner February 9, 2024 00:44
@MicroFish91
Copy link
Contributor

MicroFish91 commented Feb 9, 2024

(I'm running with advanced because there are no resources currently available to test on basic.)

It seems like I'm never prompted about creating a log analytics workspace, but the output logs indicate it's being defaulted to an existing resource. Is this intended behavior?

image

@nturinski
Copy link
Member Author

(I'm running with advanced because there are no resources currently available to test on basic.)

What's the error? If you increase the sku, that will usually resolve the issue.

It seems like I'm never prompted about creating a log analytics workspace, but the output logs indicate it's being defaulted to an existing resource. Is this intended behavior?

Yeah, there's nothing to really pick and as far as I know, no benefit to really having a bunch of workspaces. I'll confirm with the App Service team, but that is the intended behavior. You must have had one created with a function app at some point.

@MicroFish91
Copy link
Contributor

MicroFish91 commented Feb 12, 2024

What's the error? If you increase the sku, that will usually resolve the issue.

image

I assume being internal during high demand is the reason

Copy link
Contributor

@MicroFish91 MicroFish91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked Advanced and compared resources against the docs, so LGTM. I'll double check Basic if it becomes available, but approving so as not to block you.

@nturinski
Copy link
Member Author

Are you using the free tier?

@MicroFish91
Copy link
Contributor

It reproduces on all the tiers offered via quick picks

@nturinski nturinski merged commit 5490c6e into main Feb 12, 2024
5 checks passed
@nturinski nturinski deleted the nat/aiworkspaces branch February 12, 2024 18:48
@microsoft microsoft locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants