Add analyzer to detect when a class has more than one ImportingConstructor attribute
#287
Labels
Comments
|
Agreed. We should first ensure that discovery on the part produces the error in the log for guaranteed discoverability without the help of analyzers and an open source project. |
AArnott
pushed a commit
that referenced
this issue
Oct 30, 2024
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.11.0 to 17.11.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.11.0...v17.11.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A class I was modifying was long and the existing constructor wasn't at the top of the file, so I added another. I assume the error was written to the ComponentModelCache/Microsoft.VisualStudio.Default.err file, but neither compiling nor running the experimental instance gave me any indication about this error. I was just lucky that CI tests hit a code path where another component tried to import this class.
Anyway, if the analyzer checked for classes that have more than one
[ImportingConstructor], this type of error would be caught more quickly.The text was updated successfully, but these errors were encountered: