Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ContractNameServices+methods public #155

Open
znakeeye opened this issue Aug 14, 2019 · 1 comment
Open

Make ContractNameServices+methods public #155

znakeeye opened this issue Aug 14, 2019 · 1 comment

Comments

@znakeeye
Copy link

Often when writing workarounds for shortcomings in a library, it is preferable to avoid reflection and re-writing string functions. In vs-mef one of the internal classes is often involved for keys in e.g. hash tables:

internal static class ContractNameServices // internal :(
{
    // ...
    internal static string GetTypeIdentity(Type type, bool formatGenericName) // internal :(
    // a.s.o.
}

I believe it would be helpful if this class and its methods were public.

@AArnott
Copy link
Member

AArnott commented Feb 18, 2020

What is the situation where you need this, but aren't in a PartDiscovery-derived class that can reach this member via the PartDiscovery.GetContractName protected member?

AArnott added a commit that referenced this issue Jun 7, 2022
Fix several Install-DotNetSdk issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants