Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gasol] Add new port #9550

Merged
merged 9 commits into from
May 7, 2020
Merged

[gasol] Add new port #9550

merged 9 commits into from
May 7, 2020

Conversation

mayankkt9
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes issue [New Port Request] <GASol> #9507
    support for new port GASol - A general Genetic Algorithm Solver in C++

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    tested x86-windows and osx

  • Does your PR follow the maintainer guide?
    Yes

@JackBoosY JackBoosY self-requested a review January 6, 2020 02:35
@JackBoosY JackBoosY self-assigned this Jan 6, 2020
@JackBoosY JackBoosY mentioned this pull request Jan 6, 2020
Closed
@mayankkt9 mayankkt9 marked this pull request as ready for review January 6, 2020 22:01
@vicroms
Copy link
Member

vicroms commented Jan 6, 2020

/azp run

1 similar comment
@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

x64-windows/x64-windows-static build failure:

error MSB4126: The specified solution configuration "Release|x64" is invalid. Please specify a valid solution configuration using the Configuration and Platform properties

@vicroms vicroms changed the title [New Port Request] <GASol> [gasol] Add new port Jan 30, 2020
@LilyWangL
Copy link
Contributor

Pinging @mayankkt9 for response. Is work still being done for this PR?

@mayankkt9
Copy link
Contributor Author

Pinging @mayankkt9 for response. Is work still being done for this PR?

I need help regarding what should I do next

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 15, 2020
@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request Apr 28, 2020
Merged
strega-nil
strega-nil reviewed May 1, 2020
View reviewed changes
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label May 6, 2020
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request May 6, 2020
Merged
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

Alright, this looks good to me! Thanks @mayankkt9

@strega-nil strega-nil merged commit 0bee296 into microsoft:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mayankkt9 @vicroms @JackBoosY @LilyWangL @ras0219-msft @strega-nil @SanaJahan