Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wepoll] Add new port #8280

Merged
merged 2 commits into from
Sep 28, 2019
Merged

[wepoll] Add new port #8280

merged 2 commits into from
Sep 28, 2019

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Sep 21, 2019

@piscisaureus
Copy link

Library author here: cool to see a vcpkg port of my library.
However I would strongly suggest basing it off the 'dist' branch (https://github.com/piscisaureus/wepoll/tree/dist) instead of 'master'.

The master branch has a weird cmake setup that I really hope to overhaul one day when I have the time for it, while the dist branch contains just a single .c file that contains everything the end user needs and nothing more.

@myd7349
Copy link
Contributor Author

myd7349 commented Sep 27, 2019

Hi! @piscisaureus Thanks for your reply. I have switched to the dist branch. Since it doesn't contains a CMakeLists.txt on dist branch, so I wrote a simplified version in this PR.

@myd7349 myd7349 marked this pull request as ready for review September 28, 2019 03:56
@cbezault cbezault merged commit 60c5814 into microsoft:master Sep 28, 2019
@myd7349 myd7349 deleted the wepoll-init branch September 29, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants