Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grppi] Add new port #8125

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Conversation

NancyLi1013
Copy link
Contributor

GrPPI is a header-only library. It doesn't currently support Intel compiler.
I try to add test as feature at first and find that there are many problems when building test.
Especially on Windows, except for some unsupported commands, experimental/optional cannot be found in many files. Even though I have updated them as optional, it will cause many other issues.
So I disable test now.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Sep 11, 2019
@NancyLi1013
Copy link
Contributor Author

Related issue #5375.

@NancyLi1013 NancyLi1013 marked this pull request as ready for review September 11, 2019 02:56
Copy link
Contributor

@cbezault cbezault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the version. We only add revision numbers when we need to.

ports/grppi/CONTROL Outdated Show resolved Hide resolved
@dan-shaw dan-shaw merged commit 5b42add into microsoft:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants