Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port for libsrtp #8046

Merged
merged 3 commits into from
Sep 12, 2019
Merged

Port for libsrtp #8046

merged 3 commits into from
Sep 12, 2019

Conversation

sipsorcery
Copy link
Contributor

No description provided.

@vicroms
Copy link
Member

vicroms commented Sep 9, 2019

Build fails for UWP, are these failures expected?

vicroms
vicroms requested changes Sep 11, 2019
View reviewed changes
ports/libsrtp/portfile.cmake Outdated
SHA512 59afa25df79f875d28eefe95ef89b5956b1d2f319bba38ec34b832c2faa16b5425aae2f6ad19cf478afe02b28f4032b5dcf20a301d647d897d4577f66ca77376
)

set(VCPKG_C_FLAGS "${VCPKG_C_FLAGS} -D_CRT_SECURE_NO_WARNINGS /wd4703")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines should be inside an if block:

if (VCPKG_TARGET_IS_WINDOWS)
endif()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vicroms vicroms merged commit c85d63b into microsoft:master Sep 12, 2019
@vicroms
Copy link
Member

vicroms commented Sep 12, 2019

Thanks for the PR!

@sipsorcery sipsorcery deleted the srtp branch September 12, 2019 06:22
@sipsorcery
Copy link
Contributor Author

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms requested changes

Assignees

@vicroms vicroms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sipsorcery @vicroms