Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[raylib] update to 2.5.0 #7848

Merged
merged 1 commit into from
Sep 3, 2019
Merged

[raylib] update to 2.5.0 #7848

merged 1 commit into from
Sep 3, 2019

Conversation

AlvinZhangH
Copy link
Contributor

Relate: #7835

@AlvinZhangH AlvinZhangH added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 23, 2019
@valenotary
Copy link

can we get this merged to master please : )

cbezault
cbezault suggested changes Aug 27, 2019
View reviewed changes
ports/raylib/portfile.cmake
@@ -20,8 +20,8 @@ include(vcpkg_common_functions)
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO raysan5/raylib
REF f37e55a77bd6177dbaea4d7f484961c09104e104
SHA512 57146ebc7ab22a4e60c1d9eecd4c7a8f1930d6709f45761af809da9ea4f161e9fd450fa1042252a80bd7952ed9571a5d8dee4d454c8903a778e3e1328300b2bd
REF a9f33c9a8962735fed5dd1857709d159bc4056fc # 2.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just write 2.5.0 honestly I would be fine if you just updated to the HEAD of master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbezault see issue #7835,user need update to 2.5 (not 2.5-dev!).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author of raylib says 2.5-dev is REALLY outdated compared to the 2.5 release, so the file itself needs to be updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with having the commit ID instead of the release tag. We have had problems with release tags changing the tagged commit and invalidating our SHA512.

@cbezault cbezault assigned cbezault and vicroms and unassigned cbezault Aug 27, 2019
@vicroms vicroms merged commit b8f0e2c into microsoft:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms left review comments

@valenotary valenotary valenotary left review comments

@cbezault cbezault cbezault requested changes

Assignees

@vicroms vicroms

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlvinZhangH @valenotary @cbezault @vicroms