Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[easyhook]Add new port. #7487

Merged
merged 4 commits into from
Aug 2, 2019
Merged

[easyhook]Add new port. #7487

merged 4 commits into from
Aug 2, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 31, 2019 •
edited
Loading

Easyhook:

  1. Only supports windows.
  2. Can only be built as a dynamic library.
  3. Building arm/uwp is not supported.

Related: #1304.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 31, 2019
@JackBoosY JackBoosY marked this pull request as ready for review August 1, 2019 05:27
@Rastaban Rastaban merged commit ed7822f into microsoft:master Aug 2, 2019
@JackBoosY JackBoosY deleted the dev/jack/1304 branch August 2, 2019 00:57
@lanyizi
Copy link
Contributor

lanyizi commented Jul 11, 2020

Sorry for necroposting, but it looks like EasyHookDll_32.rc includes afxres.h, which will trigger build error if we don't have MFC/ATL installed.
Actually people say it can be replaced with windows.h:
EasyHook/EasyHook#210
I'm not very familiar with ports and patches, but I guess it's possible to change this through patches?

@JackBoosY
Copy link
Contributor Author

@BSG-75 Of course, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rastaban Rastaban Rastaban left review comments

Assignees
No one assigned
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @lanyizi @Rastaban