Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-winextras, ecsutil, soundtouch] Fix build-depends #7298

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

LilyWangL
Copy link
Contributor

Atlmfc is a windows only package. So modify atlmfc to atlmfc (windows) in CONTROL.
Related issue: #4645

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 17, 2019
@LilyWangL LilyWangL marked this pull request as ready for review July 17, 2019 07:46
@Rastaban
Copy link
Contributor

ecsutil and qt5-winutils support only windows so they don't need to be updated, although I guess it does not hurt anything if they are...

@Rastaban Rastaban merged commit 8ac43f1 into microsoft:master Jul 17, 2019
@JackBoosY
Copy link
Contributor

@Rastaban I think we should create a feture for vcpkg to directly determine the platform supported by the port, so that if the current platform is not supported when starting the build, it will terminate directly, preventing the port from being built.

@heydojo
Copy link
Contributor

heydojo commented Jul 18, 2019

@Rastaban I think we should create a feture for vcpkg to directly determine the platform supported by the port, so that if the current platform is not supported when starting the build, it will terminate directly, preventing the port from being built.

Alternatively - ensure that the root of the dependency tree for a build is deterministically platform specific. The same should also apply to the way that the resulting files install.

Of course, doing so might require an architectural change within vcpkg unless there is an easy way to shoehorn the method in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants