-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt5]Fix build failure in linux #7230
[qt5]Fix build failure in linux #7230
Conversation
@Rastaban PR-Eager does not seem to work, and ports that have changed have not been rebuilt. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Forcing a full rebuild under https://dev.azure.com/vcpkg/public/_build/results?buildId=5553. The CI system will cache results so on later runs if there are no changes beyond what was already tested it just pulls the cached results instead of rebuilding the ports. This caching is global so identical changes in separate PRs will also be found. My guess is that it found results from the windows static build PR and did not actually rebuild everything in this one. Forcing a full rebuild gets around that (although some of the failures may be unrelated flaky ports) |
@Rastaban Yeah, I guess that is the reason. It might be better to set a cache for each PR. |
@Rastaban Qt5 and its components were built successfully. And 4 ports failed to build(no dependency with qt5):
|
@JackBoosY we have discussed making a separate cache for each PR, but it would cause a full rebuild on the first run which would would mean the test would take 19 hours to complete. Also flaky ports (such as bond/ogdf/vxl/itk) would show up in too many unrelated PRs. This looks good, Sorry it took so long for me to finish looking at it. |
Now we don't need to use
qmake_all
to build qt5 and other modules in linux, it seems to break the disabled parameters during the build. See documentation.Fix the failure of qt5 module build in linux (caused by #5293):
Related: #6962 #5655 #5362 #3859 #3644.