[Arrow] Update to Arrow v0.14.1 #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me in VS2019 :-) |
|
@grdowns I've marked this as ready for review. Thanks. Would be good to get your opinion please on the need to modify how this port is picking up Thrift, ZSTD, and ZLIB in the patch. Are there issues with those three ports in vcpkg? Or is the problem upstream with Arrow? |
|
@philjdf Arrow 0.14.1 has been released with critical bug fixes for Parquet. Since this PR has yet to be merged, might be worth bumping the version up. |
philjdf
changed the title
|
Hi @philjdf! Sorry for the wait. The PR looks good and can go through. As a side note, the ports you mentioned being picked up have been known to be a bit flaky in our CI system due, these are only false positives. Thanks for updating Arrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a smaller patch each time! Hopefully one won't be necessary at all soon!
Builds windows-x64-static, windows-x64, linux-x64. Just need to check these work downstream (in ParquetSharp), then will mark as ready for review.