Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqlite3-tool]Fix build error on arm/uwp platform. #7202

Merged
merged 1 commit into from
Jul 15, 2019
Merged

[sqlite3-tool]Fix build error on arm/uwp platform. #7202

merged 1 commit into from
Jul 15, 2019

Conversation

JackBoosY
Copy link
Contributor

Related #7192.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 9, 2019
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jul 9, 2019 •
edited
Loading

Setting sqlite3-tool OUTPUT_NAME to sqlite3 to build sqlite3[tool]:arm-uwp will cause an error in the build:

F:\vcpkg\buildtrees\sqlite3\arm-uwp-rel\sqlite3-bin.dir\package.appxManifest : error APPX0703: Manifest references file 'sqlite3-bin.exe' which is not part of the payload. [F:\vcpkg\buildtrees\sqlite3\arm-uwp-rel\sqlite3-bin.vcxproj]

Since sqlite3-tools generated sqlite.exe, the name sqlite3-bin.exe in package.appxManifest is wrong.

Can anyone have some good ideas about this issue?

@JackBoosY JackBoosY marked this pull request as ready for review July 9, 2019 11:42
@JackBoosY JackBoosY mentioned this pull request Jul 10, 2019
Closed
@Rastaban Rastaban merged commit e1870a9 into microsoft:master Jul 15, 2019
@JackBoosY JackBoosY deleted the dev/jack/fix-sqlite3-arm-uwp branch July 16, 2019 00:32
@Haeri Haeri mentioned this pull request Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbezault cbezault

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @cbezault @Rastaban