Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_configure_cmake] Add NO_CHARSET_FLAG option #7074

Merged
merged 5 commits into from
Jun 30, 2019
Merged

[vcpkg_configure_cmake] Add NO_CHARSET_FLAG option #7074

merged 5 commits into from
Jun 30, 2019

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Jun 27, 2019 •
edited
Loading

Allow ports to bypass setting the character set to /utf-8 by adding a new option NO_CHARSET_FLAG that can be passed to vcpkg_configure_cmake().

@vicroms vicroms added the info:internal This PR or Issue was filed by the vcpkg team. label Jun 27, 2019
@vicroms vicroms requested a review from ras0219-msft June 27, 2019 21:15
@vicroms
Copy link
Member Author

vicroms commented Jun 27, 2019

Supersedes #6673

@vicroms vicroms requested a review from PhoebeHui June 27, 2019 21:40
@vicroms vicroms self-assigned this Jun 27, 2019
@PhoebeHui
Copy link
Contributor

Thanks!

@vicroms vicroms merged commit e2049cb into microsoft:master Jun 30, 2019
@vicroms vicroms mentioned this pull request Jun 30, 2019
Closed
@vicroms vicroms deleted the pr/bypass-charset-flag branch October 27, 2020 06:13
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@vicroms
[vcpkg_configure_cmake] Add NO_CHARSET_FLAG option (microsoft#7074)
58da6bd 
* [vcpkg_configure_cmake] Add NO_CHARSET_FLAG option

* [vcpkg_configure_cmake] Add documentation for new NO_CHARSET_FLAG option

* [vcpkg_configure_cmake, windows toolchain] Handle NO_CHARSET_FLAG in toolchain

* [build.cpp] Add Windows toolchain to package hash

* [duilib,msix,thrift,tidy-html5] Use NO_CHARSET_FLAG to fix regressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

@PhoebeHui PhoebeHui Awaiting requested review from PhoebeHui

Assignees

@vicroms vicroms

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicroms @PhoebeHui