-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt5-base]Add a print message to inform the user to install the dependency package. #6983
[qt5-base]Add a print message to inform the user to install the dependency package. #6983
Conversation
… libglu1-mesa-dev in linux
not every disto uses apt though. is there a way to not exclude RPM and other package managers? |
Usually we just write a message to the user. |
Switch to just printing out a message. If mesa is required on linux then you could check if it is installed and then print an error message that has the apt command. |
cmake is it will run in interactive mode? Yes, and many it just does not install, due to the many dependencies I think it is necessary to do Mesa port it is more reasonable option |
I would like a change from apt-get to "the package manager of your distribution" or something like that :) |
/azp run |
@Rastaban PR-Eager error is due to download source failed, I just added two lines of message. |
@JackBoosY |
@voskrese Using status to notify users is not a good idea because it may be confused with other status information. |
color ? example
|
@voskrese Such as: |
Why not proc for the existence of the header file(s) the build requires? The variable INCLUDEPATH usually holds the includes on Linux systems AFAIK and something more like : if(EXISTS ${INCLUDEPATH}/mesa/someheader.h)
message(STATUS "Found required external dependency someheader.h")
else()
message(FATAL_ERROR "Please install the required packages containing someheader.h using your distribution's software manager. On Debian Linux the packages are named: libgl1-mesa-dev and libglu1-mesa-dev")
endif() I will add too that Fedora, OpenSuse, Manjaro, Mint, Arch and Alpine likely won't all share the same names for these packages. Which creates another problem. |
@heydojo Sorry, I‘m not sure which header file should be used to check the packages. Can you provide them? |
Dependency resolution for things like this is one of cmake's strong points. When looking for mesa GLU: Looks like you are looking for the file Other Linux variants you would need to check yourself. I don't use or recommend any others. |
This is consistent with how other packages handle external dependencies on Linux so I am okay with the current state of this PR. Adding the check for |
…m/JackBoosY/vcpkg into dev/jack/qt5_base_add_dep_package # Conflicts: # ports/qt5-base/portfile.cmake
When qt5 is installed in Linux, we need two packages:
And users may not have installed them, so I added a print message to inform to install them.